Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dry up custom immutable Map.Entry implementations #89153

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Dry up custom immutable Map.Entry implementations #89153

merged 1 commit into from
Aug 8, 2022

Conversation

original-brownbear
Copy link
Member

Follow-up to #88815.
No need to have two equivalent implementations here.

@original-brownbear
Dry up custom immutable Map.Entry implementations
b501d77 
Follow-up to elastic#88815.
No need to have two equivalent implementations here.
@original-brownbear original-brownbear added >non-issue :Core/Infra/Core Core issues without another label v8.5.0 labels Aug 7, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Aug 7, 2022
grcevski
grcevski approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@original-brownbear
Copy link
Member Author

Thanks Nikola!

@original-brownbear original-brownbear merged commit 2429dbc into elastic:main Aug 8, 2022
@original-brownbear original-brownbear deleted the dry-up-map-entry-impl branch August 8, 2022 17:03
@original-brownbear original-brownbear restored the dry-up-map-entry-impl branch April 18, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@original-brownbear @elasticsearchmachine @grcevski